JuliaVTK / WriteVTK.jl

Julia package for writing VTK XML files

Other

155 stars 33 forks source link

Adding a new function `pvtk_grid` to generate parallel file formats (e.g. .pvtu) files. #90

Closed fverdugo closed 3 years ago

fverdugo commented 3 years ago

Hi @jipolanco,

@amartinhuertas and I have implemented a new function pvtk_grid to generate parallel file formats.

In particular, we need this to export simulation results in pvtu format from our parallel code GridapDistributed.jl. As far as we could tell, this was not available before in WriteVTK.

We believe that this is a feature that many users can benefit from and thus we happily put some effort in preparing this PR. We have also documented the usage of this function in the README.md file.

We hope you find this PR useful.

jipolanco commented 3 years ago

Hi @fverdugo and @amartinhuertas,

This is definitely a great addition to WriteVTK! Thanks a lot for the PR and for all the effort.

I will take a look at the PR in more detail and let you know if I have any comments, and I hope that it can be merged soon.

fverdugo commented 3 years ago

@amartinhuertas I'll try to address the comments

amartinhuertas commented 3 years ago

Ok @fverdugo let me know the comments which might be pending to address

codecov-commenter commented 3 years ago

Codecov Report

Merging #90 (ec2f401) into master (f9f2429) will increase coverage by 0.81%. The diff coverage is 98.96%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   92.32%   93.14%   +0.81%     
==========================================
  Files          15       16       +1     
  Lines         691      788      +97     
==========================================
+ Hits          638      734      +96     
- Misses         53       54       +1

Impacted Files	Coverage Δ
src/WriteVTK.jl	`84.21% <ø> (ø)`
src/gridtypes/pvtk_grid.jl	`98.96% <98.96%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9f2429...ec2f401. Read the comment docs.

fverdugo commented 3 years ago

@jipolanco @fredrikekre I have addressed your comments. I have also tried to simplify a bit the code.

jipolanco commented 3 years ago

Looks good to me! Thanks again for the PR. I'll try to push a new version soon.