search

JuliaWaveScattering / MultipleScattering.jl

A Julia library for simulating, processing, and plotting multiple scattering of waves.
Other
45 stars 12 forks source link

Boundary conditions test fails randomly #1

Closed jondea closed 6 years ago

jondea commented 6 years ago

The boundary conditions test uses randomly generated particles, and this sometimes cause the test to fail (example). We need to make the test more permissive (but still strong), or alternatively use a seed which is known to pass.

arturgower commented 6 years ago

I think choosing a seed makes more sense. Then we can still be rather stringent on the boundary test.

jondea commented 6 years ago

I agree we should choose a seed eventually, but it worries me slightly that it fails so often. Do you know where it is failing?

jondea commented 6 years ago

Displacement jumps are suppose to be strictly decreasing in k, but here's an example where it ever so slightly isn't: 0.00013567, 0.000133472

Pretty minimal tbh.

arturgower commented 6 years ago

I've solved this by using one specific seed to generate the random particles. I forgot to tag this issue in my commit...