search

JuliaWaveScattering / MultipleScattering.jl

A Julia library for simulating, processing, and plotting multiple scattering of waves.
Other
45 stars 12 forks source link

Change the type of `FrequencySimulationResult.ω` from `RowVector` in to just `Vector`? #24

Closed arturgower closed 5 years ago

arturgower commented 5 years ago

As of Julia 1.0, RowVector is no longer a thing. See this issue.

Instead there is a type Transpose, Adjoint, or just Array{2}. All in all, I think there is plenty of room for confusion now, and the intuitive idea of having a "lying down" vector is lost. So I suggest just using Vector for the type FrequencySimulationResult.ω.

jondea commented 5 years ago

I agree, also thanks for working on moving to Julia 1.0!