Closed andyDoucette closed 2 years ago
The "Simple Example" at https://github.com/JuliaWaveScattering/MultipleScattering.jl doesn't work.
Run the "Simple Example":
using MultipleScattering using Plots # 2D acoustic medium with density ρ = 1.0 and soundspeed c = 1.0 host_medium = Acoustic(2; ρ=1.0, c=1.0); # 2D acoustic particle with density ρ = 10.0 and soundspeed c = 2.0 particle_medium = Acoustic(2; ρ=10.0, c=2.0); p1 = Particle(particle_medium, Sphere([-2.0,2.0], 2.0)); p2 = Particle(particle_medium, Sphere([-2.0,-2.0], 0.5)); particles = [p1,p2]; source = plane_source(host_medium; direction = [1.0,0.0]) simulation = FrequencySimulation(particles, source) x = [[-10.0,0.0], [0.0,0.0]] max_ω = 1.0 ω = 0.01:0.01:max_ω result = run(simulation, x, ω) time_result = frequency_to_time(result) # plot(time_result) plot(simulation,0.8) gui()
No error
ERROR: UndefVarError: bounding_rectangle not defined Stacktrace: [1] macro expansion @ ~/.julia/packages/MultipleScattering/mcGmd/src/plot/plot.jl:62 [inlined] [2] apply_recipe(plotattributes::AbstractDict{Symbol, Any}, sim::FrequencySimulation{Float64, 2, Acoustic{Float64, 2}}, ω::Float64) @ MultipleScattering ~/.julia/packages/RecipesBase/92zOw/src/RecipesBase.jl:282 [3] _process_userrecipes!(plt::Any, plotattributes::Any, args::Any) @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BY2Dd/src/user_recipe.jl:36 [4] recipe_pipeline!(plt::Any, plotattributes::Any, args::Any) @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BY2Dd/src/RecipesPipeline.jl:70 [5] _plot!(plt::Plots.Plot, plotattributes::Any, args::Any) @ Plots ~/.julia/packages/Plots/SVksJ/src/plot.jl:172 [6] plot(::Any, ::Vararg{Any, N} where N; kw::Any) @ Plots ~/.julia/packages/Plots/SVksJ/src/plot.jl:58 [7] plot(::Any, ::Any) @ Plots ~/.julia/packages/Plots/SVksJ/src/plot.jl:52 [8] top-level scope @ REPL[51]:1
Julia version: Version 1.6.2
[deps] MultipleScattering = "80a8ab25-5750-5d93-a6d7-4adc97cdd5fb"
# This file is machine-generated - editing it directly is not advised [[Adapt]] deps = ["LinearAlgebra"] git-tree-sha1 = "84918055d15b3114ede17ac6a7182f68870c16f7" uuid = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" version = "3.3.1" [[ArgTools]] uuid = "0dad84c5-d112-42e6-8d28-ef12dabb789f" [[Artifacts]] uuid = "56f22d72-fd6d-98f1-02f0-08ddc0907c33" [[Base64]] uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f" [[CompilerSupportLibraries_jll]] deps = ["Artifacts", "Libdl"] uuid = "e66e0078-7015-5450-92f7-15fbd957f2ae" [[Dates]] deps = ["Printf"] uuid = "ade2ca70-3891-5945-98fb-dc099432e06a" [[Distributed]] deps = ["Random", "Serialization", "Sockets"] uuid = "8ba89e20-285c-5b6f-9357-94700520ee1b" [[Downloads]] deps = ["ArgTools", "LibCURL", "NetworkOptions"] uuid = "f43a241f-c20a-4ad4-852c-f6b1247861c6" [[GSL]] deps = ["GSL_jll", "Libdl", "Markdown"] git-tree-sha1 = "3ebd07d519f5ec318d5bc1b4971e2472e14bd1f0" uuid = "92c85e6c-cbff-5e0c-80f7-495c94daaecd" version = "1.0.1" [[GSL_jll]] deps = ["Artifacts", "JLLWrappers", "Libdl", "Pkg"] git-tree-sha1 = "9a6d2b6c33aa7061654d2f1b31d9f7e1c2bd2dbc" uuid = "1b77fbbe-d8ee-58f0-85f9-836ddc23a7a4" version = "2.7.1+0" [[HalfIntegers]] git-tree-sha1 = "8aeed192be8b368c9f5c149806db90f4451c8bb1" uuid = "f0d1745a-41c9-11e9-1dd9-e5d34d218721" version = "1.3.3" [[InteractiveUtils]] deps = ["Markdown"] uuid = "b77e0a4c-d291-57a0-90e8-8db25a27a240" [[JLLWrappers]] deps = ["Preferences"] git-tree-sha1 = "642a199af8b68253517b80bd3bfd17eb4e84df6e" uuid = "692b3bcd-3c85-4b1f-b108-f13ce0eb3210" version = "1.3.0" [[LibCURL]] deps = ["LibCURL_jll", "MozillaCACerts_jll"] uuid = "b27032c2-a3e7-50c8-80cd-2d36dbcbfd21" [[LibCURL_jll]] deps = ["Artifacts", "LibSSH2_jll", "Libdl", "MbedTLS_jll", "Zlib_jll", "nghttp2_jll"] uuid = "deac9b47-8bc7-5906-a0fe-35ac56dc84c0" [[LibGit2]] deps = ["Base64", "NetworkOptions", "Printf", "SHA"] uuid = "76f85450-5226-5b5a-8eaa-529ad045b433" [[LibSSH2_jll]] deps = ["Artifacts", "Libdl", "MbedTLS_jll"] uuid = "29816b5a-b9ab-546f-933c-edad1886dfa8" [[Libdl]] uuid = "8f399da3-3557-5675-b5ff-fb832c97cbdb" [[LinearAlgebra]] deps = ["Libdl"] uuid = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" [[Logging]] uuid = "56ddb016-857b-54e1-b83d-db4d58db5568" [[Markdown]] deps = ["Base64"] uuid = "d6f4376e-aef5-505a-96c1-9c027394607a" [[MbedTLS_jll]] deps = ["Artifacts", "Libdl"] uuid = "c8ffd9c3-330d-5841-b78e-0817d7145fa1" [[MozillaCACerts_jll]] uuid = "14a3606d-f60d-562e-9121-12d972cd8159" [[MultipleScattering]] deps = ["GSL", "LinearAlgebra", "OffsetArrays", "Printf", "ProgressMeter", "Random", "RecipesBase", "SpecialFunctions", "StaticArrays", "Statistics", "WignerSymbols"] git-tree-sha1 = "505fbc04c05ebbb01baf06deb5024a871936470b" uuid = "80a8ab25-5750-5d93-a6d7-4adc97cdd5fb" version = "0.1.8" [[NetworkOptions]] uuid = "ca575930-c2e3-43a9-ace4-1e988b2c1908" [[OffsetArrays]] deps = ["Adapt"] git-tree-sha1 = "c0f4a4836e5f3e0763243b8324200af6d0e0f90c" uuid = "6fe1bfb0-de20-5000-8ca7-80f57d26f881" version = "1.10.5" [[OpenSpecFun_jll]] deps = ["Artifacts", "CompilerSupportLibraries_jll", "JLLWrappers", "Libdl", "Pkg"] git-tree-sha1 = "13652491f6856acfd2db29360e1bbcd4565d04f1" uuid = "efe28fd5-8261-553b-a9e1-b2916fc3738e" version = "0.5.5+0" [[Pkg]] deps = ["Artifacts", "Dates", "Downloads", "LibGit2", "Libdl", "Logging", "Markdown", "Printf", "REPL", "Random", "SHA", "Serialization", "TOML", "Tar", "UUIDs", "p7zip_jll"] uuid = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" [[Preferences]] deps = ["TOML"] git-tree-sha1 = "00cfd92944ca9c760982747e9a1d0d5d86ab1e5a" uuid = "21216c6a-2e73-6563-6e65-726566657250" version = "1.2.2" [[Primes]] deps = ["Test"] git-tree-sha1 = "ff1a2323cb468ec5f201838fcbe3c232266b1f95" uuid = "27ebfcd6-29c5-5fa9-bf4b-fb8fc14df3ae" version = "0.4.0" [[Printf]] deps = ["Unicode"] uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7" [[ProgressMeter]] deps = ["Distributed", "Printf"] git-tree-sha1 = "afadeba63d90ff223a6a48d2009434ecee2ec9e8" uuid = "92933f4c-e287-5a05-a399-4b506db050ca" version = "1.7.1" [[REPL]] deps = ["InteractiveUtils", "Markdown", "Sockets", "Unicode"] uuid = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb" [[Random]] deps = ["Serialization"] uuid = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" [[RationalRoots]] git-tree-sha1 = "4165f49c451e6fc4bc0a2eeb1250abdf8c6e550e" uuid = "308eb6b3-cc68-5ff3-9e97-c3c4da4fa681" version = "0.1.0" [[RecipesBase]] git-tree-sha1 = "b3fb709f3c97bfc6e948be68beeecb55a0b340ae" uuid = "3cdcf5f2-1ef4-517c-9805-6587b60abb01" version = "1.1.1" [[SHA]] uuid = "ea8e919c-243c-51af-8825-aaa63cd721ce" [[Serialization]] uuid = "9e88b42a-f829-5b0c-bbe9-9e923198166b" [[Sockets]] uuid = "6462fe0b-24de-5631-8697-dd941f90decc" [[SparseArrays]] deps = ["LinearAlgebra", "Random"] uuid = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" [[SpecialFunctions]] deps = ["OpenSpecFun_jll"] git-tree-sha1 = "d8d8b8a9f4119829410ecd706da4cc8594a1e020" uuid = "276daf66-3868-5448-9aa4-cd146d93841b" version = "0.10.3" [[StaticArrays]] deps = ["LinearAlgebra", "Random", "Statistics"] git-tree-sha1 = "da4cf579416c81994afd6322365d00916c79b8ae" uuid = "90137ffa-7385-5640-81b9-e52037218182" version = "0.12.5" [[Statistics]] deps = ["LinearAlgebra", "SparseArrays"] uuid = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" [[TOML]] deps = ["Dates"] uuid = "fa267f1f-6049-4f14-aa54-33bafae1ed76" [[Tar]] deps = ["ArgTools", "SHA"] uuid = "a4e569a6-e804-4fa4-b0f3-eef7a1d5b13e" [[Test]] deps = ["InteractiveUtils", "Logging", "Random", "Serialization"] uuid = "8dfed614-e22c-5e08-85e1-65c5234f0b40" [[UUIDs]] deps = ["Random", "SHA"] uuid = "cf7118a7-6976-5b1a-9a39-7adc72f591a4" [[Unicode]] uuid = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5" [[WignerSymbols]] deps = ["HalfIntegers", "Primes", "RationalRoots"] git-tree-sha1 = "dfb49a51c4c8e205d1d7ddc7e6a1a29da871ef52" uuid = "9f57e263-0b3d-5e2e-b1be-24f2bb48858b" version = "1.1.0" [[Zlib_jll]] deps = ["Libdl"] uuid = "83775a58-1f1d-513f-b197-d71354ab007a" [[nghttp2_jll]] deps = ["Artifacts", "Libdl"] uuid = "8e850ede-7688-5339-a07c-302acd2aaf8d" [[p7zip_jll]] deps = ["Artifacts", "Libdl"] uuid = "3f19e933-33d8-53b3-aaab-bd5110c3b7a0"
This PR fixes it.
Issue
The "Simple Example" at https://github.com/JuliaWaveScattering/MultipleScattering.jl doesn't work.
Procedure
Run the "Simple Example":
Expected
No error
What I get:
Environment
Julia version: Version 1.6.2
Project.toml
Manifest.toml