fix Dict deprecation warnings closes #23

JuliaWeb / GnuTLS.jl

Transport Level Security for Julia Streams provided by GnuTLS

Other

8 stars 13 forks source link

fix Dict deprecation warnings closes #23 #24

Closed milktrader closed 10 years ago

coveralls commented 10 years ago

Changes Unknown when pulling 481a70a3eab90e0d0315a306b75397e3b2978af2 on milktrader:master into \ on JuliaWeb:master**.

milktrader commented 10 years ago

This PR is premature as it only addresses syntax changes in v0.4

sbromberger commented 9 years ago

@milktrader - I just (inadvertently) submitted a similar PR. What do you mean that yours was premature?

milktrader commented 9 years ago

The warnings only apply to v0.4 and removing them would involve syntax change that doesn't apply to v0.3, thereby breaking the package on v0.3, which is the current stable release.

Does your PR have a control flow like this?

if VERSION < v"0.4-"
    # use new syntax
else
    # use old syntax
end

The Compat package is designed to take of this but I haven't actually used the package yet.

sbromberger commented 9 years ago

I did it using Compat and using @compat before Dict. This works in 0.3 and 0.4.

milktrader commented 9 years ago

Cool!

I need to learn this. Can you point me to your code?

sbromberger commented 9 years ago

I take it back :) @compat broke 0.4. It's fixed now. Check out my PR for details: https://github.com/JuliaWeb/GnuTLS.jl/pull/28/files .