search

JuliaWeb / GnuTLS.jl

Transport Level Security for Julia Streams provided by GnuTLS
Other
8 stars 13 forks source link

Modified hotfix for something funny with sockets/sessions, updated licen... #36

Closed sbromberger closed 9 years ago

sbromberger commented 9 years ago

...se

this works

cleanup

possible readall() fix

irb/tempfix plus some other functionality

see, e.g., https://github.com/osstech-jp/openldap/commit/6ad808dc1db41fabf29a80842649f1105782f890

typo in license

removed commented code

IainNZ commented 9 years ago

Looks like we also need #35 in there to get it passing on 0.4

sbromberger commented 9 years ago

did you confirm that? I was unable to reproduce #35 in 0.4.

IainNZ commented 9 years ago

See: https://travis-ci.org/JuliaWeb/GnuTLS.jl/jobs/51184449

sbromberger commented 9 years ago

That's very weird. Could it be because the version of libgnutls is so old?

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 0a3b0ac9c29c78faf76b3b01b48f9fdde9d16bd5 on sab/fixup1 into \ on master**.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 9ee72bc84d0767337aa9ecbe05cddc8dd3591659 on sab/fixup1 into \ on master**.

sbromberger commented 9 years ago

As an aside, why are there two (identical?) travis jobs being submitted?

staticfloat commented 9 years ago

I believe one builds this PR as-is, and one builds this PR after merging it into master.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 9ee72bc84d0767337aa9ecbe05cddc8dd3591659 on sab/fixup1 into \ on master**.

sbromberger commented 9 years ago

All checks passed. I'll go ahead and merge.

staticfloat commented 9 years ago

Just for posterity's sake, I did a bisect session and discovered that the Base.write() stuff was because of https://github.com/JuliaLang/julia/commit/2af73dd7723c91b0e9fcf5af7662b40c8fb97067

sbromberger commented 9 years ago

@staticfloat thanks for checking. When was that change made? I see it was authored 29 days ago, but on my 14-day-old build I didn't have a problem.

Edit: ah. https://github.com/JuliaLang/julia/commit/ab5c4cfa296037c5b5be42e11dd742ff5060593e was two days ago. That explains why @timholy's stuff started failing at that time.

Awesome detective work. Thanks for chasing that down.