search

JuliaWeb / Gumbo.jl

Julia wrapper around Google's gumbo C library for parsing HTML
Other
154 stars 25 forks source link

Adding julia compatibility to 1.6 #91

Closed AbhimanyuAryan closed 2 years ago

AbhimanyuAryan commented 2 years ago

platforms = supported_platforms(; experimental=true) requires a minimum of 1.5 Julia. I'm trying build it for Macbook M1 following this bug https://github.com/JuliaWeb/Gumbo.jl/issues/90

aviks commented 2 years ago

This should change the package version, and be done after the yggdrasil change is merged.

giordano commented 2 years ago

Why is this required?

AbhimanyuAryan commented 2 years ago

ok then we need to tag a new version of Gumbo.jl using Gumbo_jll v0.10.2+0 support @giordano ?

giordano commented 2 years ago

No, you don't need to do anything.

aviks commented 2 years ago

Why is this required?

Because I was told that any jll with M1 support needed to be lower bound at Julia v1.6. If that is not the case, well, how would I know? Will pkg handle the transitive lower bound? Even with patch version numbers on jlls? I can never be sure.

giordano commented 2 years ago

Because I was told that any jll with M1 support needed to be lower bound at Julia v1.6.

That's correct, and in fact I had to change the version number of the jll package in order to require Julia v1.6 in https://github.com/JuliaPackaging/Yggdrasil/pull/4149/files

Will pkg handle the transitive lower bound? Even with patch version numbers on jlls? I can never be sure.

Yes, the package manager will find the latest versions available of both Gumbo and Gumbo_jll for the current version of Julia, without having to do anything here. At some point you may want to require Julia v1.6 here because that's the new LTS, but that's unrelated to the need of being able to use latest version of Gumbo_jll, which already works: https://github.com/JuliaWeb/Gumbo.jl/issues/90#issuecomment-1003730951