Open pankgeorg opened 1 year ago
Merging #1103 (811b6b3) into master (8f35185) will increase coverage by
0.04%
. The diff coverage is89.06%
.
@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
+ Coverage 82.34% 82.38% +0.04%
==========================================
Files 32 33 +1
Lines 3042 3089 +47
==========================================
+ Hits 2505 2545 +40
- Misses 537 544 +7
Files Changed | Coverage Δ | |
---|---|---|
src/HTTP.jl | 67.05% <ø> (ø) |
|
src/WebSockets.jl | 87.50% <ø> (ø) |
|
src/Servers.jl | 79.90% <88.23%> (-0.31%) |
:arrow_down: |
src/accept.jl | 90.00% <90.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
So, this is a bit speculative, but I'm very very concerned about the backlog getting big; I think it's always a good idea to get through as many accepts as possible, before spawning the tasks to handle the connections. This builds on https://github.com/JuliaWeb/HTTP.jl/pull/1102 and adds a
acceptmany
function that returns a vector of accepted connections, if they are available.I've run some benchmarks (this commit) on this and it seems that it helps for the benchmarks that are connection intensive:
see latency-average for plaintext and json (the db related queries also benefit from async query send)