HTTP.request(): infer `socket_type_tls` from `sslconfig`, if provided

cmcaine commented 10 months ago

Fixes #1104.

This PR only affects client requests, because those were the only ones broken. For now OpenSSL is not supported in HTTP.jl servers.

I didn't just revert the change to SOCKET_TYPE_TLS[] because that change has been released for months and users may now be relying on sslconfig accepting an OpenSSL.SSLContext value, just as I was relying on it accepting an MbedTLS.SSLConfig value.

codecov-commenter commented 10 months ago

Codecov Report

Merging #1106 (acc4286) into master (8f35185) will increase coverage by 0.46%. Report is 8 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   82.34%   82.81%   +0.46%     
==========================================
  Files          32       32              
  Lines        3042     3072      +30     
==========================================
+ Hits         2505     2544      +39     
+ Misses        537      528       -9

Files	Coverage Δ
src/clientlayers/ConnectionRequest.jl	`81.03% <100.00%> (+4.74%)`	:arrow_up:

... and 7 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmcaine commented 3 months ago

Bump. I think this is still relevant.

cmcaine commented 3 months ago

You're welcome! Thanks for writing HTTP.jl :)

JuliaWeb / HTTP.jl

HTTP.request(): infer `socket_type_tls` from `sslconfig`, if provided #1106

Codecov Report