Open pankgeorg opened 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5cd586d
) 82.70% compared to head (64d36e2
) 82.71%. Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I tried seeing if there was somewhere else we could enforce this (like startwrite or unsafe_write for Stream)
@quinnj why did you dismiss this idea? Seems like we could bail early in
https://github.com/JuliaWeb/HTTP.jl/blob/a2ce750aa28765d0bb6f905c41f11919173a3457/src/Streams.jl#L85 just like if n = 0
? This would take care of both request handler and stream handler, I think?
I tried seeing if there was somewhere else we could enforce this (like startwrite or unsafe_write for Stream)
@quinnj why did you dismiss this idea? Seems like we could bail early in
https://github.com/JuliaWeb/HTTP.jl/blob/a2ce750aa28765d0bb6f905c41f11919173a3457/src/Streams.jl#L85
just like if
n = 0
? This would take care of both request handler and stream handler, I think?
n = 0
is totally stateless and always correct to be a no-op, while the check for HEAD also needs to know that the headers are already written and the current bytes to write are part of the body (and not the headers).
(Note: if you're using your own
streamhandler
, you're on your own) fixes: https://github.com/JuliaWeb/HTTP.jl/issues/1112with this fix, 3 connections fly over the same connection with cURL