search

JuliaWeb / HTTP.jl

HTTP for Julia
https://juliaweb.github.io/HTTP.jl/stable/
Other
626 stars 177 forks source link

Rename from `connection_timeout` -> `connect_timeout` #1131

Closed staticfloat closed 7 months ago

staticfloat commented 7 months ago

I think this may be a typo; I'm a little surprised there's not a warning or something that you're using a useless keyword argument.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7bdb45c) 82.69% compared to head (37be604) 82.69%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1131 +/- ## ======================================= Coverage 82.69% 82.69% ======================================= Files 32 32 Lines 3052 3052 ======================================= Hits 2524 2524 Misses 528 528 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fredrikekre commented 7 months ago

kwargs... are just forwarded down the chain at all stages I think. Perhaps at the end there should be a check that all kwargs have been picked up by some layer below.

Edit: #1024