search

JuliaWeb / HTTP.jl

HTTP for Julia
https://juliaweb.github.io/HTTP.jl/stable/
Other
635 stars 176 forks source link

Update readbytes! to avoid using internal API of IOBuffer less #1148

Closed vtjnash closed 7 months ago

vtjnash commented 7 months ago

Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which pointer(data) is contiguous space

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.62%. Comparing base (040cf0a) to head (6f3353f).

Files Patch % Lines
src/Streams.jl 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1148 +/- ## ========================================== - Coverage 82.67% 82.62% -0.05% ========================================== Files 32 32 Lines 3054 3051 -3 ========================================== - Hits 2525 2521 -4 - Misses 529 530 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vtjnash commented 7 months ago

Alright, I think I fixed the remaining test issues so this is passing on all versions now

oscardssmith commented 7 months ago

bumping this.