search

JuliaWeb / HTTP.jl

HTTP for Julia
https://juliaweb.github.io/HTTP.jl/stable/
Other
635 stars 176 forks source link

Introduce `connections_lock` to protect `Server.connections` #1161

Closed Drvi closed 6 months ago

Drvi commented 6 months ago

The listenloop deletes elements from the connections set, but if someone tries to close the server at the same time, this could lead to crashes.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 83.19%. Comparing base (c495600) to head (320c83d).

Files Patch % Lines
src/Servers.jl 77.77% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1161 +/- ## ========================================== - Coverage 83.19% 83.19% -0.01% ========================================== Files 32 32 Lines 3053 3058 +5 ========================================== + Hits 2540 2544 +4 - Misses 513 514 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.