search

JuliaWeb / HTTP.jl

HTTP for Julia
https://juliaweb.github.io/HTTP.jl/stable/
Other
626 stars 177 forks source link

Introduce connections_lock to protect Server.connections (backport 1.9) #1162

Closed Drvi closed 3 months ago

Drvi commented 3 months ago

Backport of https://github.com/JuliaWeb/HTTP.jl/pull/1161

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (release-1.9@f20777d). Click here to learn what that means.

Files Patch % Lines
src/Servers.jl 77.77% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.9 #1162 +/- ## ============================================== Coverage ? 82.49% ============================================== Files ? 32 Lines ? 3056 Branches ? 0 ============================================== Hits ? 2521 Misses ? 535 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Drvi commented 3 months ago

I think release-1.9 is missing some fixes by Jameson which makes master pass on nightly (#1146, #1148, #1149)

Drvi commented 3 months ago

@quinnj Would you be ok with merging this backport?

quinnj commented 3 months ago

Sure thing; go ahead