JuliaWeb / Hyperscript.jl

Hyperscript: A lightweight DOM representation for Julia
Other
101 stars 11 forks source link

Invalid call to validateattrs #15

Closed kskyten closed 5 years ago

kskyten commented 5 years ago

Running

using Hyperscript
m("div")

raises the following error on the current version in the package registry:

ERROR: MethodError: no method matching validateattrs(::Hyperscript.Validate{true}, ::String, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}})
Closest candidates are:
validateattrs(::Hyperscript.Validate, ::Any, ::NamedTuple) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:80
validateattrs(::Hyperscript.NoValidate, ::Any, ::NamedTuple) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:94
Stacktrace:
[1] Hyperscript.Node(::Hyperscript.Validate{true}, ::String, ::Tuple{}, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:111
[2] #m#7(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::String) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:174
[3] m(::String) at ~/.julia/packages/Hyperscript/qO5ub/src/Hyperscript.jl:174
[4] top-level scope at none:0
yurivish commented 5 years ago

Hi, can you see if this happens using the master branch? It may be that the latest version just wants a proper release — I haven’t made one since Julia 1.0, I think.

kskyten commented 5 years ago

Seems to be working in master.

SimonDanisch commented 5 years ago

Yes, can we make a new release? :) We're at 375 commits to master since this release ;)

yurivish commented 5 years ago

Poke me in a few weeks when I have a little more time — we should make a new release. :)

SimonDanisch commented 5 years ago

To you want to transfer it to an org we both have access to? I could make a release, if you want

yurivish commented 5 years ago

I just added you as a collaborator to this repository. Does that give you adequate permissions to make a release?

SimonDanisch commented 5 years ago

Let's try ;)

yurivish commented 5 years ago

Thanks for the release. I'm closing this issue now since the fix has been deployed.