Closed aviks closed 4 years ago
FreeBSD test failure seems unrelated. Works for windows and linux.
Merging #78 into master will decrease coverage by
6.51%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
- Coverage 13.33% 6.81% -6.52%
=========================================
Files 2 2
Lines 75 132 +57
=========================================
- Hits 10 9 -1
- Misses 65 123 +58
Impacted Files | Coverage Δ | |
---|---|---|
src/LibCURL.jl | 36.36% <ø> (-5.31%) |
:arrow_down: |
src/lC_curl_h.jl | 4.13% <0.00%> (-3.81%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5cfd2e4...1c65a7b. Read the comment docs.
@omus let me know if you have any concerns with this. I'll merge and tag this soon-ish otherwise.
This looks great! I'll just check the failing FreeBSD test and go from there. I think what I'll do is I'll merge my open PR and then we can rebase these changes. That should make it more obvious what is going on when looking at the merged/closed PRs.
Incorporated into #75
Incorporates #75, and fixes the SSL certificate problem by supplying the mozilla CA bundle with the jll.
[Edit] I've removed the
@test_broken
annotation for the ssl tests in windows and bsd. Tests should now pass on all platforms.