search

JuliaWeb / LibCURL.jl

Julia wrapper for libcurl
Other
33 stars 29 forks source link

Vararg ABI on PowerPC #95

Closed vchuravy closed 3 years ago

vchuravy commented 3 years ago

Should fix https://github.com/JuliaLang/julia/issues/38628

On most platforms this doesn't make a difference, but on PPC the callee can overrride the callers stack, see https://github.com/JuliaLang/julia/pull/30821

vchuravy commented 3 years ago

Does indeed seem to fix the issue on PowerPC.

vchuravy commented 3 years ago

@keno maybe you can take a look to double-check that I am using the Vararg correctly?

vchuravy commented 3 years ago

@StefanKarpinski if this looks ok to you, could you merge this?

StefanKarpinski commented 3 years ago

Did you edit these files manually?

vchuravy commented 3 years ago

Did you edit these files manually?

Yes I did.

StefanKarpinski commented 3 years ago

Ok, that's not ideal since these files are generated, but I don't actually know how to generate these files in the condition they were generated in and when I've tried to regenerate them I get very different results that don't work, so I think we have to essentially view this code base as no longer being something we can generate. Ideally, someone would figure out how to use Clang.jl to generate working bindings from a more recent version of Clang and libcurl in a way that satisfies the ABI on all platforms, but for now it seems fine to merge this.