Clean up connections before exit in tests

JuliaWeb / RemoteREPL.jl

Connect a REPL to a remote Julia process

MIT License

120 stars 11 forks source link

Clean up connections before exit in tests #71

Closed c42f closed 1 month ago

c42f commented 1 month ago

This fixes various alarming finalizer errors when running the tests - in those cases, sockets appear to have been closed before the finalizer gets to run.

Also make sure to run the test RemoteREPL server processes in the Julia environment set up by the test runner.

Fix #70

c42f commented 1 month ago

@filchristou Indeed, it seems we're using ssh in CI... Now I'm confused, I don't know why I thought this didn't work!

Looking at the CI config it seems I did spend a lot of effort getting ssh working back in #2. Honestly I can't remember going through that pain :laughing: