Leave throttling functions up to the user

JuliaWeb / WebSockets.jl

A WebSockets library for Julia

MIT License

157 stars 58 forks source link

Leave throttling functions up to the user #138

Closed hustf closed 5 years ago

hustf commented 5 years ago

The functionality we have previously supplied worked in a non-intuitive way. Now, the user must also provide a throttling function if such a one is needed.

modified: src/HTTP.jl Remove throttling function. This only has an effect if a ratelimit was previously supplied. modified: test/runtests.jl Remove throttling_test deleted: test/throttling_test.jl Remove

hustf commented 5 years ago

Had to update the default rate limit value in two other places. Duplicated code smells. Minus points for having several interfaces right there...

coveralls commented 5 years ago

Coverage increased (+1.8%) to 81.481% when pulling ba940ba6a5c407db4e1f2ad3de975d7b98f51260 on issue124 into b694930254ede76efce6940275c071eb59fc8879 on master.