allow IPAddr in serve - Githubissues

JuliaWeb / WebSockets.jl

A WebSockets library for Julia

MIT License

157 stars 58 forks source link

allow IPAddr in serve #145

Closed piever closed 5 years ago

piever commented 5 years ago

Mux uses this code and passes the IP address directly (say localhost = ip"0.0.0.0"::IPAddr). In this way serve supports both passing the string and passing the IPAddr object.

coveralls commented 5 years ago

Coverage increased (+0.03%) to 94.041% when pulling e7f55b90e87e93cc50fd18aa7e5c3ac287e0e246 on piever:pv/ip into 187ebe9006ca16a0863147748d5823beec38fd07 on JuliaWeb:master.

hustf commented 5 years ago

Do you see other similar needs at this point? Will probably merge and release tomorrow morning if not, after another look.

piever commented 5 years ago

Thanks, a release would be great. As far as I can see, this was the only thing that needed fixing on the WebSockets side.

piever commented 5 years ago

I've added tests and addressed the feedback, I think this should be good to merge.

hustf commented 5 years ago

Absolutely magnificent! One less for issue #147.