JuliaWeb / WebSockets.jl

A WebSockets library for Julia
MIT License
158 stars 57 forks source link

Add Project.toml #162

Closed cmcaine closed 3 years ago

cmcaine commented 3 years ago

Pkg.dev on Julia 1.6 was giving me an error without one. I couldn't easily test the package, either.

cmcaine commented 3 years ago

The tests fail locally for me, but they failed before I made this change, too, so idk.

Doing this partly so I can try to close https://github.com/JuliaWeb/Mux.jl#113.

hustf commented 3 years ago

Thanks! I don't see why the testing setup can't find Test. The test is going to fail anyway due to some minor changes in the printing format. I'm merging this to make further testing easier.

This package is in need of some maintenance, but I believe it's of value as a backup for HTTP.Websockets, as that package is doing some experimentation now.

christopher-dG commented 3 years ago

You need to add:

[extras]
Test = "TEST-UUID-HERE"

[targets]
test = ["Test"]

And then Test will be picked up as a test-only dependency.

hustf commented 3 years ago

@cmcaine, would you have the change to follow up Christopher's helpful comment with another PR? Locally, it's working out of the box of course.

cmcaine commented 3 years ago

On Julia 1.6 I didn't need those lines, but I'll add them and test on whatever older Julia I have installed :)

I wonder if we're actually still compatible with Julia 0.7? Do you care about maintaining compat with that?

hustf commented 3 years ago

I just tested, too, and we can say WebSockets is working on Julia 0.4.7. Although that's version v0.3 that is being downloaded, nobody's left in the lurch by dropping support of old Julia versions.

Julia 0.7 version was the hardest one to support well due to all the deprecation messages. After dropping it from future versions, I believe some alternative tests could be dropped. But the important fix will be to update 'travis.yml' and 'appveyor.yml'.

In my experience, getting things to work on those testing services is a lot more difficult than having tests work locally, so be warned. If you work in a pull request that you update, I believe you can read the online test logs and possibly retrigger the tests in case you suspect a failure was just a fluke.