search

JuliaWeb / WebSockets.jl

A WebSockets library for Julia
MIT License
157 stars 58 forks source link

Add test dependencies for older Julia #163

Closed cmcaine closed 3 years ago

cmcaine commented 3 years ago

See https://julialang.github.io/Pkg.jl/v1.5/creating-packages/#Test-specific-dependencies-in-Julia-1.0-and-1.1

See also #162

cmcaine commented 3 years ago

Older Julias don't work on my machine, so I'm just going to see if the CI likes it.

cmcaine commented 3 years ago

CI passes for v0.7 but fails on v1 and nightly due to what look like unrelated reasons. Seems good to merge to me?

hustf commented 3 years ago

Yes. The logging failure is another issue. Do you need a tag now, too? If not I might get around to fixing it before tagging a new version.

cmcaine commented 3 years ago

I'm not in a rush for a new tag :)

On Wed, 9 Dec 2020, 19:27 hustf, notifications@github.com wrote:

Yes. The logging failure is another issue. Do you need a tag now, too? If not I might get around to fixing it before tagging a new version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaWeb/WebSockets.jl/pull/163#issuecomment-741996261, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNZA6OLDWI5RN756MB5ASLST7FTTANCNFSM4UT4BUTQ .