Julian / lean.nvim

Neovim support for the Lean theorem prover
MIT License
277 stars 26 forks source link

Support neovim 0.5 again #135

Closed gebner closed 3 years ago

gebner commented 3 years ago

Restores 0.5 support. The CI runs checks on both 0.5 and nightly now.

codecov[bot] commented 3 years ago

Codecov Report

Merging #135 (2b54f04) into main (50f2a59) will decrease coverage by 0.20%. The diff coverage is 81.25%.

:exclamation: Current head 2b54f04 differs from pull request most recent head e201464. Consider uploading reports for the commit e201464 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   93.81%   93.61%   -0.21%     
==========================================
  Files          36       36              
  Lines        2134     2145      +11     
==========================================
+ Hits         2002     2008       +6     
- Misses        132      137       +5     
Impacted Files Coverage Δ
lua/lean/trythis.lua 90.69% <80.00%> (-9.31%) :arrow_down:
lua/tests/helpers.lua 97.57% <80.00%> (-0.21%) :arrow_down:
lua/lean/lsp.lua 66.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50f2a59...e201464. Read the comment docs.

gebner commented 3 years ago

Not sure what's going on with the search path test. The function only fails when called from the test, but not if I open nvim and run :echo luaeval('require"lean".current_search_paths()') manually.

rish987 commented 3 years ago

(sorry, am working on generalizing phaazon/hop.nvim in support of #123, will look into test failures soon)

gebner commented 3 years ago

Tests pass on 0.5 now, but the neovim nightly builds are gone temporarily so now the other tests fail :-( https://github.com/neovim/neovim/issues/15709

The only thing I've changed since yesterday is the backported list_workspace_folders function though, so the tests should pass with nightly once the builds are back up.

Julian commented 3 years ago

Hooray, thanks!