search

Julian / lean.nvim

neovim support for the Lean theorem prover
MIT License
248 stars 25 forks source link

Deprecated Commands in Neovim 0.11 #342

Closed ArvinSKushwaha closed 1 month ago

ArvinSKushwaha commented 2 months ago

Here is the traceback for the :checkhealth vim.deprecated command:


- WARNING vim.lsp.for_each_buffer_client() is deprecated. Feature will be removed in Nvim 0.12
  - ADVICE:
    - use lsp.get_clients({ bufnr = bufnr }) with regular loop instead.
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/lsp.lua:26
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/rpc.lua:173
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/rpc.lua:219
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:987
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1074
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:949
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/lsp.lua:26
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/lsp.lua:40
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1007
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1074
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:949
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/lsp.lua:26
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/lsp.lua:58
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1032
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1074
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:949

 ~
- WARNING vim.lsp.get_active_clients() is deprecated. Feature will be removed in Nvim 0.12
  - ADVICE:
    - use vim.lsp.get_clients() instead.
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:182
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1243
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1145
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1162
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1205
        [C]:-1
        /usr/share/nvim/runtime/filetype.lua:36
        [C]:-1
        /usr/share/nvim/runtime/filetype.lua:35
        [C]:-1
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/init.lua:693
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/adapters/files.lua:257
        vim/_editor.lua:0
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:22
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview/components.lua:296
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1063
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1074
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:949
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1151
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1162
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1205
        [C]:-1
        /usr/share/nvim/runtime/filetype.lua:36
        [C]:-1
        /usr/share/nvim/runtime/filetype.lua:35
        [C]:-1
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/init.lua:693
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/adapters/files.lua:257
        vim/_editor.lua:0
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1151
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1162
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1205
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/ftdetect/lean.lua:4
        [C]:-1
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/init.lua:693
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/adapters/files.lua:257
        vim/_editor.lua:0
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1151
        [C]:-1
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/init.lua:693
        /home/<user_name>/.local/share/nvim/lazy/oil.nvim/lua/oil/adapters/files.lua:257
        vim/_editor.lua:0
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
    - stack traceback:
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/_util.lua:280
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:848
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:792
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:919
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:713
        [C]:-1
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:311
        /home/<user_name>/.local/share/nvim/lazy/lean.nvim/lua/lean/infoview.lua:1151

The changes to be made should be pretty simple, and I can make a PR if you would like. If preferred, I can also gate the changes with vim.fn.has.

Julian commented 2 months ago

Thanks! A PR would be very much appreciated!

Also very much appreciated in a separate PR if you have time would be to see if there's a way we could have the nightly builds fail on warnings, which would alert us a bit quicker (otherwise I'll get to that at some point).