search

Julian / venvs

venvs creates virtualenvs
https://pypi.org/project/venvs/
MIT License
17 stars 12 forks source link

Edit config file automatically when installing from CLI #65

Closed energizah closed 5 years ago

energizah commented 5 years ago

This adds a dependency on tomlkit, which says

It includes a parser that preserves all comments, indentations, whitespace and internal element ordering, and makes them accessible and editable via an intuitive API.

energizah commented 5 years ago

I think I need a hand with the py2 unicode error. I'm not sure what the polyglot idiom is to do this under filesystems.

Julian commented 5 years ago

This ready for re-review? (no pressure if not, just making sure I'm not leaving you hanging :)

energizah commented 5 years ago

Yeah I think so. Some decision will be needed about whether to keep tomlkit. And I'm not sure what's going on with the CI -- the last change was just whitespace for flake8 and now some tests failed.

Julian commented 5 years ago

OK let's stick with tomlkit for now I suppose and will see how it goes.

energizah commented 5 years ago

Any thoughts on the failure in 3.5?

Julian commented 5 years ago

Hm, not from just reading the CI output, and unfortunately I don't have easy access to 3.5 while I'm away from home to be able to actually try to reproduce.