search

Julian / venvs

venvs creates virtualenvs
https://pypi.org/project/venvs/
MIT License
17 stars 12 forks source link

Intermittent build failures on cpy3.5, proooobably because tomlkit isn't preserving order when loading files #74

Closed Julian closed 4 years ago

altendky commented 5 years ago

What, I have to go fix this in another TOML library for you? :]

avakar/pytoml#39

Julian commented 5 years ago

Hahhhhhhh oy.

This one came from @energizerhub :) I don't remember why we had to switch even because it took me a year to merge his PR but seems at least likely that this is why based on the symptoms, since 3.5 didn't have ordered dicts on cpython.

altendky commented 5 years ago

https://github.com/sdispater/tomlkit/blob/cad4e0a8aebe000d7009f103986d0f1b2dec7347/tomlkit/container.py#L26

Awesome... Inheriting from dict.

Julian commented 4 years ago

The easiest solution was just dropping support for 3.5, hooray.