search

JulianAssmann / flutter_background

A flutter plugin to keep apps running in the background via foreground services. Android only.
https://pub.dev/packages/flutter_background
MIT License
86 stars 46 forks source link

Stop IsolateHolderService when app is killed with swipe to remove #10

Closed ksncho closed 3 years ago

ksncho commented 3 years ago

Hello. This package is great and I am using it well. and I am appreciated your work.

I can stop IsolateHolderService with stop "FlutterBackground.disableBackgroundExecution()". But when I kill app with swipe to remove action at recent apps, the service is still there. I googled and found this solution.

This is my first time to create PR and I am not sure this is right way. But I wish this will help you.

If you feel bad, please ignore this PR.

JulianAssmann commented 3 years ago

Thank you very much for your pull request. I tested it and it indeed fixes the problem you encountered.

As this would be a new version, could you please increase the version in pubspec.yaml to 0.1.3 and add a description of this change to CHANGELOG.md?

After that, LGTM.

ksncho commented 3 years ago

All done! :)

JulianAssmann commented 3 years ago

Thank you very much :)