Declare the holder service in AndroidManifest.xml

JulianAssmann / flutter_background

A flutter plugin to keep apps running in the background via foreground services. Android only.

https://pub.dev/packages/flutter_background

MIT License

85 stars 45 forks source link

Declare the holder service in AndroidManifest.xml #75

Open inetic opened 1 year ago

inetic commented 1 year ago

Without it the IsolateHolderService won't start. See issue https://github.com/JulianAssmann/flutter_background/issues/69

Perhaps the reasoning behind this change was that users should declare the service in the application's AndroidManifest.xml, but this has not been communicated in the README.

Or would you prefer that in this PR, instead of modifying the AndroidManifest.xml of this plugin, change the README to instruct the user to add the service section to their own AndroidManifest.xml?

vmwsree commented 12 months ago

does this fix issue on new version

asifakhtar98 commented 9 months ago

What is the outcome of this change?