JulianAssmann / flutter_background

A flutter plugin to keep apps running in the background via foreground services. Android only.
https://pub.dev/packages/flutter_background
MIT License
89 stars 52 forks source link

[Feature Request] Remove references to deprecated v1 Android embedding #88

Closed reidbaker closed 3 months ago

reidbaker commented 3 months ago

Remove references to deprecated v1 Android embedding

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

Consequences:

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: https://github.com/flutter/engine/pull/52022

emersion commented 3 months ago

Would you be willing to send a PR for this?

reidbaker commented 3 months ago

Sorry there are over 100 plugins that need to be migrated and I don't expect to get to this one.

reidbaker commented 3 months ago

https://github.com/search?q=repo%3AJulianAssmann%2Fflutter_background%20%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)%20&type=code

Github search to hopefully help make the removal easier.