JulianEberius / SublimePythonIDE

ST3 only: A rewrite of SublimeRope for ST3, uses the Rope library to add python completions and refactoring to ST3
GNU General Public License v2.0
267 stars 38 forks source link

Don't try to retrieve completions for apparently non-Python expressions #75

Closed protoss-player closed 3 years ago

protoss-player commented 9 years ago

For some reason the completion listener experienced insane lags when typing in non-ASCII characters, e.g. in Russian.

I haven't tried to identify the root cause of the issue yet, since this workaround seems to be enough to fix the plugins performance issue with long non-English docstrings.

JulianEberius commented 8 years ago

Thanks for bringing this up. I'll have a look at it and merge and soon as I can.

Thanks again for this contribution Julian

JulianEberius commented 8 years ago

Hi again!

Finally got some spare time to work a bit on SublimePythonIDE. I couldn't reproduce the issue so far, tried various non-english unicode characters (>256) in my source code. Can you send me some test case that triggers the lagging for you? Also some more information, such as the Platform you're testing on (Win/Linux/OSX) would be of interest...

Julian

protoss-player commented 8 years ago

Hi Julian,

I'll try to reproduce the issue in a couple of days. Not sure if it's still there though, since the pull request is quite old.

FYI, my platform was Ubuntu 64bit.

protoss-player commented 8 years ago

Hi Julian,

It looks like there was an update to the SublimePythonIDE package recently, which wiped out my manually applied patches. After that I'm experiencing the same issue. I've captured some screencasts, please notice the package's CPU consumption difference between English and Russian input. Also, input lag in Russian version is noticeable even in a GIF capture :)

I'll try applying my patches again later today and will report whether they fix the issue.

UPDATE: I've re-applied the patch, and I can confirm that it still fixes the issue on the latest package installation.

EN: sublime_en

RU: sublime_ru

protoss-player commented 3 years ago

This project is stale, hence closing my PR.

JulianEberius commented 3 years ago

@protoss-player Yes, sorry! No time or personal interest anymore, especially since there are more complete alternatives such as https://packagecontrol.io/packages/Anaconda .

Sorry again.