JulianEberius / SublimePythonIDE

ST3 only: A rewrite of SublimeRope for ST3, uses the Rope library to add python completions and refactoring to ST3
GNU General Public License v2.0
267 stars 38 forks source link

Feature: use jedi for `definition_location` instead of rope #82

Closed asfaltboy closed 3 years ago

asfaltboy commented 8 years ago

For me, the main reason for this change is that Jedi has support for following flask.ext imports.

Jedi's functionality differs from rope in (at least) one noticeable way:

I tried both, and goto_assignments feels more natural to me, since it stops on each assignment/import, and I can choose to keep following or not.

I've made the method settable in settings with all 3 options: rope/jedi-assignemnts/jedi-definitions.

I kept the previous rope as the default behaviour, but I would advocate changing the default to jedi-assignments. While this may surprise current SublimePythonIDE users since it will now require another click each time an import statement is reached, I believe this explicit behavior is more correct and that using Jedi outweighs the "new interface learning curve".

@JulianEberius Please let me know how you feel, and I'll make adjustments accordingly.

asfaltboy commented 8 years ago

@JulianEberius bump?