JulianGaibler / atlas

Theme Manger for Figma
6 stars 4 forks source link

Can't export local map with styles that are not assigned to theme #1

Closed lukasoppermann closed 3 years ago

lukasoppermann commented 3 years ago

Hey, as I mentioned on twitter, this is a great plugin. 👍

Issue

When I have styles that are not assigned to a theme, the plugin does not let me export the local map. It does not seem to matter if the colors are private (prefixed with a "_") or published but not added to a theme.

You can find a Figma file with the setup in this file: https://www.figma.com/file/zcKtsKdjoHHXtqttx47tbH/Bug-report?node-id=0%3A1

Screenshot 2021-01-29 at 10 45 18 Screenshot 2021-01-29 at 10 45 26 Screenshot 2021-01-29 at 10 45 32

Use case

A very typical use case is that you define a theme in a file where you also define base colors. However you only want to export the theme colors, the base colors are supposed to just be internal (prefixed with "_" to not be published) or not part of a theme at least.

JulianGaibler commented 3 years ago

Thanks for digging into it and giving such a detailed error description. I really appreciate it!

lukasoppermann commented 3 years ago

Thank you for fixing it. Works great. 👍

lukasoppermann commented 3 years ago

Just in case somebody comes here. Sometimes the issue is that you changed styles and they are not published. This also creates an "Unkown error".