search

JulianGaibler / atlas

Theme Manger for Figma
6 stars 4 forks source link

Include effect styles into themes #2

Closed lukasoppermann closed 3 years ago

lukasoppermann commented 3 years ago

Hey @JulianWels,

At my company I am currently working on the light and dark themes using your fantastic plugin. With the fix from #1 it works like a charm now.

I did run into an issue though: Effects / Shadows / Elevation is different for dark and light mode (black shadows don't work well on black BGs 😉 ). It would be great if the plugin could integrate effect styles using the same theme name as well. (E.g. Light / Elevation / 01 dp → Dark / Elevation / 01 dp)

JulianGaibler commented 3 years ago

Hi! Theming should work for color-, effect- and text-styles and I can't reproduce the issue in my test project.

Could you provide steps to reproduce or some screenshots, so we can narrow it down?

lukasoppermann commented 3 years ago

Hey @JulianWels I just never tried it. I didn't see it in the video tutorial, so I assumed it was not supported. 😉 Awesome, to learn it is. Works perfect. 👍