search

JulianHayward / AzAdvertizer

AzAdvertizer helps you to keep up with the pace by providing overview and insights on new releases and changes/updates for Azure Governance capabilities such as Azure Policy's policy definitions, initiatives (set definitions), aliases, security & regulatory compliance controls and Azure RBAC's role definitions and resource provider operations.
https://www.azadvertizer.net/
25 stars 1 forks source link

Sync issues with community policies #10

Closed maxime-roy closed 2 months ago

maxime-roy commented 4 months ago

Describe the bug Hi!

I think there might be an issue with the synchronization of the community policies. From AzAdvertizer, I'm not able to see the policy 4f8668bc-8adc-44fc-b6e1-20cf37dc6738, but it's available here on the main branch .

Thanks !

JulianHayward commented 4 months ago

ho!

good catch and thanks for reporting.

Checked and found three not synced policies, due to that the files are .jsonc whilst the syncer looks for .json (actually azurepolicy.json)

There seem no comments in the files at all, so changing the file extensions should be straight forward. Would you be willing to raise the PRs against the community repo?

maxime-roy commented 4 months ago

Will do!

Maybe at some point the syncer could support jsonc by stripping the comments before "ingesting it " ?

DFRZ7 commented 3 months ago

@maxime-roy @JulianHayward Hi, we have presented a PR for this. Should be accepted in a couple of days. Thank you. https://github.com/Azure/Community-Policy/pull/452