search

JulianHayward / Azure-MG-Sub-Governance-Reporting

Azure Governance Visualizer aka AzGovViz is a PowerShell script that captures Azure Governance related information such as Azure Policy, RBAC (a lot more) by polling Azure ARM, Storage and Microsoft Graph APIs.
MIT License
817 stars 295 forks source link

psrule - not reporting tls correctly #152

Closed nb2708 closed 1 year ago

nb2708 commented 1 year ago

Hi, I've deployed azgovviz for a couple tenants i am working on. On both tenants under psrule, tls is showing as less than 1.2 for nearly every app service and storage account (i.e. for one subscription 68/71 app services are showing as non compliant when they are compliant with tls 1.2).

Not sure if this is an issue with psrule or azgov and whether you may have seen this before? Would really appreciate any help

JulianHayward commented 1 year ago

hi, there have been some fixes, please try the latest release

nb2708 commented 1 year ago

I've just tried pulling the latest version and re running with the same issue.

I believe ps rule is checking for the siteconfig.mintlsversion property for webapps for example, however; if I run get-azwebapp in cli and get this property it shows the correct tls version therefore i would think ps rule would be picking this up. Happy to give more info if you need it regarding config.

JulianHayward commented 1 year ago

please see https://github.com/Azure/PSRule.Rules.Azure/issues/1919
will reference

JulianHayward commented 1 year ago

AzGovViz / PSRule integration under review. Findings and decision on how to proceed will be posted soon. Closing for now.