Closed reza8iucs closed 1 year ago
seems you have deployed a static web app, whilst the pipeline is designed for a web app. Please check the setup guide. FYI: the errors from the 'Run AzGovViz' step are just dumps (handled by the script)
Thanks @JulianHayward . You are correct! I made a mistake!
Changed it to the Web App and was able to deploy. I would make it clearer that this wont work with static web app, especially these days that Static Web App is being presented as a "valid sku" when you are creating your Web App ( I know it's for marketing , but still :))
A few more feedbacks for your consideration:
1) It would be great to clarify on Management Group ID and Tenant ID in the guide (e.g. same if you want the tool to analyze from the root, could be different otherwise? )
2) Subscription ID. What subscription ID should be specified? Where the Web App is deployed Or the scope the tool should starts the analysis? I know you have WebAppSubscriptionId in the YAML, but was a bit confused what to use at the beginning .
3) I'd also clarify that if you don't have the authentication enabled on the web app, the tool highly encourages you to enable it before publishing the HTMLs. This is an important behavior (and guideline) which is not very front and visible in the guide.
4) Specify which html file needs to go to the default document section of the web app. there are a few in the generated content and I was not sure which one to use. Finally ended up using the one in the root of Wiki library.
5) Add recommendations that in addition to authentication you encourage people to enable private networking (and think about making the pipeline still being able to publish to the web app)
6) In the guide, you have Linux shown as the platform chosen for the deployment of the web app but it seems you have deployed it using Windows platform. That is because later on you are showing how to change the default document of the app under configuration which is not visible in Linux based web app. Got me scratching my head for a few mins :)
7) Specify the name of "wiki" library as the location of where the html content is being published. Not the Wiki of the GitHub repository. Reading the guide I thought it would go there.
8) Provide some guidance to the advanced users who want to use Git to understand the change to output of what your tool generates by Diffing the artefacts. Would you even recommend this as an auditing/notification mechanism?
Thanks for this awesome tool @JulianHayward...I am loving it!
thanks for the valuable feedback @reza8iucs
Changed it to the Web App and was able to deploy. I would make it clearer that this wont work with static web app, especially these days that Static Web App is being presented as a "valid sku" when you are creating your Web App ( I know it's for marketing , but still :))
valid, please feel free to update the setup guide / contribute with PR A few more feedbacks for your consideration:
- It would be great to clarify on Management Group ID and Tenant ID in the guide (e.g. same if you want the tool to analyze from the root, could be different otherwise? )
well, the root management group by default comes with the same id as the tenant id, not exactly sure what to update and where
- Subscription ID. What subscription ID should be specified? Where the Web App is deployed Or the scope the tool should starts the analysis? I know you have WebAppSubscriptionId in the YAML, but was a bit confused what to use at the beginning .
there are two parameters that are relevant to subIds
-SubscriptionId4AzContext
you can use this to ensure that the context is established against that sub-WebAppSubscriptionId
that is the subId where your webApp is deployed- I'd also clarify that if you don't have the authentication enabled on the web app, the tool highly encourages you to enable it before publishing the HTMLs. This is an important behavior (and guideline) which is not very front and visible in the guide.
well, yes - assuming that enabling authentication is a no-question, but in case authentication is not enabled the pipeline will refuse to publish the html files and provides reasoning..
- Specify which html file needs to go to the default document section of the web app. there are a few in the generated content and I was not sure which one to use. Finally ended up using the one in the root of Wiki library.
they pipeline should handle that for you.. ?!
- Add recommendations that in addition to authentication you encourage people to enable private networking (and think about making the pipeline still being able to publish to the web app)
good one.. have not tried publishing against private networking enabled webApp, yet
- In the guide, you have Linux shown as the platform chosen for the deployment of the web app but it seems you have deployed it using Windows platform. That is because later on you are showing how to change the default document of the app under configuration which is not visible in Linux based web app. Got me scratching my head for a few mins :)
ok
- Specify the name of "wiki" library as the location of where the html content is being published. Not the Wiki of the GitHub repository. Reading the guide I thought it would go there.
ok
- Provide some guidance to the advanced users who want to use Git to understand the change to output of what your tool generates by Diffing the artefacts. Would you even recommend this as an auditing/notification mechanism?
Seeing all sorts of solutions here, some create alerts for certain files changing, other ingest everything to LA and create alerts..
please feel free to contribute with PR, appreciated :)
I am getting the following error in Publish HTML to Web App stage. I am pretty sure the web app exists in the right subscription and I can see the correct Az context is being set in the job's output screen:
Earlier in the execution I can see the following error in RunGovViz which I think is telling me that workflow was not able to obtain an access token. Could that be the reason it cannot find the Static Web App? My static web app is wide open and has no authentication ebaled.