JulianMar / nuxt-bugsnag

Bugsnag module for nuxt.js
MIT License
49 stars 18 forks source link

add publicPath to BugsnagSourceMapUploaderPlugin to fix sourcemaps #7

Closed dseidl closed 4 years ago

dseidl commented 4 years ago

Servus :)

add publicPath to BugsnagSourceMapUploaderPlugin in order to have right source map file urls.

instead of /_nuxt/.js it generates */_nuxt/.js

JulianMar commented 4 years ago

Hi :)

Hmm does it make a difference? In my Bugsnag Dasboard it works with the current version.

dseidl commented 4 years ago

for me it only works with the * / or the specific domain path

probably because i have a specific publicPath configured in my nuxt.config.js - so it takes that as default and then it does not match against my domain. so i would guess that the sourcemaps currently only works, when no specific publicPath is set in the build configuration of the nuxt.config.js

JulianMar commented 4 years ago

Ahh you are using a cdn for your assets. I will checkout what will happen with our assets if we add your change

JulianMar commented 4 years ago

yes it does work! I will merge the PR.

Thanks for your help!

Version 3.1.1 is now released