search

JulianMar / nuxt-bugsnag

Bugsnag module for nuxt.js
MIT License
49 stars 18 forks source link

Add pnpm support #72

Closed Jamie4224 closed 6 months ago

Jamie4224 commented 6 months ago

In the current version (7.2.3), @bugsnag/plugin-vue and @bugsnag/js are added to the optimizeDeps list so that the build tool can convert them from CommonJS to ESM in development mode. However, when using pnpm, the dependencies are not hoisted at the root and thus @bugsnag/plugin-vue and @bugsnag/js are not available.

The fix for this is specifying the optimizeDeps as nested dependencies of nuxt-bugsnag, which was done in this PR.

Please let me know if any changes are required, from my end it seems like this fixes pnpm support.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.01%. Comparing base (69ec9f4) to head (5eb1882). Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================== + Coverage 41.82% 42.01% +0.19% ========================================== Files 15 15 Lines 428 426 -2 Branches 32 32 ========================================== Hits 179 179 + Misses 249 247 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JulianMar commented 6 months ago

Thanks alot! Your changes are now in the main branch and I will do a release in a few minutes.