search

JulianNorton / subreddit-css

used for /r/web_design and /r/graphic_design
https://www.reddit.com/r/web_design
45 stars 23 forks source link

Added oveflow to correct scrolling container background bug #18

Closed jmarikle closed 10 years ago

jmarikle commented 10 years ago

Sorry about that. If a line fo code is too long for a code block, it will cause overflow and a scrollbar, but the background doesn't continue with the container and is just stuck at 100%. Adding 'overflow:auto' corrects this by forcing a new box formatting context that encompasses the whole block. See here: http://imgur.com/a/9RQhP

Pull Request Note: Now that I look at it, this change will likely conflict with #17 pull request; however, I'm not sure #17's 'overflow:hidden' is a good idea anyway. It should probably be 'overflow-y: hidden; overflow-x: auto;'. This pull request is a good fix for now, but if line numbers are implemented, this topic should probably be reviewed again.

jmarikle commented 10 years ago

*Block Formatting Context

(not box formatting context)

jmarikle commented 10 years ago

I realized that later. I suppose I should just create a more adaptable pull request. I apologize for my inefficiency. I'm not new to git, but I am new to collaborating with more than one or two other people.

jmarikle commented 10 years ago

Updated pull request. Should now be fine to implement without conflicting with the line numbers

JulianNorton commented 10 years ago

@jmarikle I can't automatically merge it, can you repull from master and resubmit?

jmarikle commented 10 years ago

Yeah. It got foobared because of an accepted/rejected pull request. I'll update it quick.

jmarikle commented 10 years ago

@JulianNorton Changes applied.