search

JulianNorton / subreddit-css

used for /r/web_design and /r/graphic_design
https://www.reddit.com/r/web_design
45 stars 24 forks source link

Add spritesheet to repo #21

Closed twolfson closed 9 years ago

twolfson commented 9 years ago

I would like to open a PR that adjusts the spritesheet. However, there are no sprites/spritesheet in this repo. Can we add it in?

Spritesheet: http://b.thumbs.redditmedia.com/yhr7iITZbB6ooHSC.png

Bonus points if you compile the spritesheet via a task to make editing individual sprites easier.

http://compass-style.org/reference/compass/utilities/sprites/

https://github.com/Ensighten/grunt-spritesmith

JulianNorton commented 9 years ago

https://github.com/JulianNorton/web_design/commit/5da5f2a93fa1b708e1be16205fe0a9250f61fea6

boom done!

I'd like to keep keep grunt/compass out of this repo, so it's only files we use in the theme.

twolfson commented 9 years ago

That makes it hard to contribute since I don't know the setup/can't test my changes. Thoughts on creating another branch (e.g. development) which publishes to master? Similar to gh-pages publication? Make sure to add tagging to have some history/versioning.

https://github.com/cburgdorf/grunt-release-branch

https://github.com/robwierzbowski/grunt-build-control

https://github.com/pajtai/grunt-build-gh-pages

https://github.com/pocesar/grunt-git-deploy

JulianNorton commented 9 years ago

If you want to test your changes, www.reddit.com/r/testtheme has been my sandbox, so feel free to pm web_design mods if you need an invite (or create your own subreddit). I recommend you get your grunt setup on your own, alternative branch, and we can revisit it down the line.

twolfson commented 9 years ago

I was hoping to preview changes via developer tools since this is an image based change. grunt is designed to make workflows reproducable across developers. Can you at least copy/paste your Gruntfile.js and npm ls?

JulianNorton commented 9 years ago

You can try asking in http://www.reddit.com/r/naut , because it was originally a naut theme. I'm not aware of any grunt/npm set-up, though I'm sure there must be. @purduekenny your 2¢? who did the flair?

twolfson commented 9 years ago

Ah, sorry. I misread. I thought those were assets you compiled using grunt. I am guessing they were done by hand. Sorry for being so forceful.

JulianNorton commented 9 years ago

Hah, no worries, I understand now.