JulianNorton / subreddit-css

used for /r/web_design and /r/graphic_design
https://www.reddit.com/r/web_design
45 stars 23 forks source link

Change z-index of .drop-choices.lightdrop #64

Closed wincohi closed 7 years ago

wincohi commented 7 years ago

This is to fix the issue of the comment text field being positioned above the drop menu, preventing it from being accessible as reported here.

EliezerB123 commented 7 years ago

I would recommend against this. I have very little experience with reddit CSS, but from what I understand of reddit standards, changing .drop-choices.lightdrop's z-index won't play nicely with other z-indexes(e.g. custom user themes), so it appears to me that a better solution would be #63 .

JulianNorton commented 7 years ago

https://github.com/JulianNorton/subreddit-css/pull/63 was too large to review, this one I could see the diff :)

Thank you!

JulianNorton commented 7 years ago

@Terrafire123 , totally valid concern. I merged because it fixes the reported issue. Welcoming any revisions or improvements 😄