JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Removing conditional statement that was hiding partials/daily with we #123

Closed Polidoro closed 7 years ago

Polidoro commented 7 years ago

Removed the showTomorrow value and associated conditional statement from index.ejs in order to always show tomorrow's weather, regardless of what time it is.

Note: It might be possible to make rendering the partials/daily view for tomorrow's weather slightly more efficient by adding a check before displaying forecast-secondary content so as to not even check it tomorrow is more than 6 hours away, but that might be overkill.

mention-bot commented 7 years ago

@Polidoro, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JulianNorton, @modelm and @ryanwr to be potential reviewers.

JulianNorton commented 7 years ago

Looks good to me, thank you for contributing!