search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

As a user, I want identical information to be condensed, so I can focus on relevant weather data #125

Closed JulianNorton closed 7 years ago

JulianNorton commented 7 years ago

2017-04-27

Polidoro commented 7 years ago

What parameters are used to determine if two hours are identical and should be condensed?

Also, can you give an example of how you want them condensed (Text only is fine).

JulianNorton commented 7 years ago

Here are three ways, I prefer 1—2pm

1–2pm

screen shot 2017-04-27 at 12 39 36 pm

screen shot 2017-04-27 at 12 39 20 pm screen shot 2017-04-27 at 12 39 02 pm

Polidoro commented 7 years ago

After further inspection, checking the weather summary (ie. "Mostly Cloudy with a 5 mph breeze") to condense hours is a little tricky, since that content is calculated in summary.ejs and we don't want to duplicate that logic in the conditional statement that decides whether or not to merge hours.

I think the best approach would be to calculate that summary first, then make the comparison, then pass it to summary.ejs (or just display it directly in daily.ejs).

Need to think about it more, feedback welcome if anyone has any.

JulianNorton commented 7 years ago

hooray! Pushed live. Thank you :)

https://github.com/JulianNorton/weather-10kb/pull/132#pullrequestreview-38477977