search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Resolve CircleCI test error #158

Closed JulianNorton closed 7 years ago

JulianNorton commented 7 years ago

What's the current situation?

https://circleci.com/gh/JulianNorton/weather-10kb/39

Exit code: 8
#!/bin/bash -eo pipefail
./node_modules/.bin/nyc -r html --report-dir reports/coverage/html ./node_modules/.bin/mocha --reporter=xunit --reporter-options output=reports/test-results.xml

What do you recommend?

Determine why the test suite is failing and recommend a resolution.

AlexSwensen commented 7 years ago

Managed to reproduce https://circleci.com/gh/AlexSwensen/weather-10kb/1 I'll tinker with it and see what I can come up with.

AlexSwensen commented 7 years ago

@JulianNorton see #159 for my initial solution.

JulianNorton commented 7 years ago

@AlexSwensen any progress? Happy to make more issues.

JulianNorton commented 7 years ago

Builds are passing, see https://github.com/JulianNorton/weather-10kb/pull/167 comments

AlexSwensen commented 7 years ago

Awesome! glad this is solved!