JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Make 'give feedback' link fixed at top-right #162

Closed wildan3105 closed 7 years ago

wildan3105 commented 7 years ago

What's the current situation?

I know this isn't an urgent situation. But it's a bit annoying to see give feedback link with dinamic position as we switch the city like picture below.

feedback

What do you recommend?

Make the postition of give feedback link static at top-right.

wildan3105 commented 7 years ago

So, do you give me a shot to fix this thing? @JulianNorton

JulianNorton commented 7 years ago

Thank you @wildan3105, please, all you!

Here's a quick edit that you might consider, giving the H1 a max-width. capture

wildan3105 commented 7 years ago

Thanks for the hint! :smile:

JulianNorton commented 7 years ago

https://github.com/wildan3105/weather-10kb/commit/3802d426393f22bc92ce5bedb021e9c8ee508057 resolves it