JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible

https://wxkb.juliannorton.com

GNU General Public License v2.0

152 stars 49 forks source link

Fix broken favicon path #169

Closed JulianNorton closed 7 years ago

JulianNorton commented 7 years ago

What's the current situation?

The favicon images are not working. This should be a valid path. https://wxkb.io/images/partly-cloudy-day/favicon.ico?v=partly-cloudy-day

What do you recommend?

git bisect to find out when the bug was introduced. That can help find out why it's broken I suspect this may be an issue with the security headers? (cc @anestv )

JulianNorton commented 7 years ago

screen shot 2017-10-07 at 9 42 47 am

ahhmarr commented 7 years ago

fixed it

171

the static files were not serving properly

JulianNorton commented 7 years ago

Thanks @ahhmarr for the contribution. How did you verify it's working? I'm still not able to render it.

screen shot 2017-10-07 at 11 56 54 am

ahhmarr commented 7 years ago

it's working fine here http://prntscr.com/gugabw

JulianNorton commented 7 years ago

Interesting, let me merge it in on production to confirm.

JulianNorton commented 7 years ago

https://wxkb.io/antartica

yeah, I'm still getting the error. Happy to jump in a discord chat to help debug

screen shot 2017-10-07 at 12 02 08 pm

ahhmarr commented 7 years ago

that's weird what i need to do to connect with discord (my id is ahhmarr)

JulianNorton commented 7 years ago

https://discord.gg/57qNS7

JulianNorton commented 7 years ago

Fixed with a server restart from @ahhmarr's PR :)