search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Change High and Low today temp to apparent temp. #184

Closed JulianNorton closed 7 years ago

JulianNorton commented 7 years ago

What's the current situation?

https://github.com/JulianNorton/weather-10kb/blob/master/views/partials/today.ejs#L18

High and Low are displaying the temp. min.

What do you recommend?

How it feels is most important in how someone should dress for the day. 30 deg. F with no wind is much different from 30 deg and 30 mph winds.

Change the High and Low to apparent temperatures.

apparentTemperatureHighTime and apparentTemperatureLow, apparentTemperatureLowTime, etc.

https://darksky.net/dev/docs

mdew192837 commented 7 years ago

I'll take care of this.

JulianNorton commented 7 years ago

Sorry @mdew192837, thank you @alfg for the PR.

@mdew192837 do you want to do the samething for https://github.com/JulianNorton/weather-10kb/blob/master/views/partials/tomorrow.ejs#L12

?

JulianNorton commented 7 years ago

https://github.com/JulianNorton/weather-10kb/issues/186