search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Enable page size limit in test #194

Closed JulianNorton closed 7 years ago

JulianNorton commented 7 years ago

What's the current situation?

We have a testing suite that runs through CircleCI, https://circleci.com/gh/JulianNorton/weather-10kb

In the past we used to have a size limit. We disabled it because it wasn't testing the compression size.

What do you recommend?

  1. View tests here: https://github.com/JulianNorton/weather-10kb/blob/master/test/integration/forecast.test.js

  2. Write a new test, or use the old test to set a size limit. I recommend making the size 30kb because it will GZIP to ~10kb, our project's page transfer maximum.

mukulmishra18 commented 7 years ago

I am working on it. Thanks.

JulianNorton commented 7 years ago

Thanks @mukulmishra18 ! Merged and deployed..

JulianNorton commented 7 years ago

cc @Tardog