search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Refactor CircleCI build settings to not fail #202

Closed JulianNorton closed 5 years ago

JulianNorton commented 6 years ago

What's the current situation?

https://circleci.com/gh/JulianNorton/weather-10kb-wxkb/126

What do you recommend?

  1. remove snyk
  2. edit https://github.com/JulianNorton/weather-10kb-wxkb/blob/master/.circleci/config.yml

For a PR, I will test if CircleCI successfully builds without throwing an error. Goal is to not throw errors!

gfranco93 commented 6 years ago

If you're running Node 10 (which I think you are because of - image: circleci/node:latest), you must be running node-sass 4.9. I can try to update node-sass

JulianNorton commented 6 years ago

new error https://circleci.com/gh/JulianNorton/weather-10kb-wxkb/127

JulianNorton commented 6 years ago
  1. Forecast location should guess the user's location based on their IP address,

That was removed on the initial load.

// todo update that test

JulianNorton commented 5 years ago

Going to close this -- CircleCI not a priority.