search

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible
https://wxkb.juliannorton.com
GNU General Public License v2.0
152 stars 49 forks source link

Missing an hour in the hourly report #209

Open modelm opened 5 years ago

modelm commented 5 years ago

What's the current situation?

Missing an hour in the hourly report for https://wxkb.io/sacramento

What do you recommend?

Change "in 5 hours and in 7 hours" to "in 5 hours until 7 hours"

image

JulianNorton commented 5 years ago

https://github.com/JulianNorton/weather-10kb-wxkb/blob/df24e95897c0fe1b30ea23944db05f140a949775/views/partials/hourly.ejs#L31

JulianNorton commented 5 years ago

https://github.com/JulianNorton/weather-10kb-wxkb/blob/master/views/partials/hourly.ejs

JulianNorton commented 5 years ago

fixed in https://github.com/JulianNorton/weather-10kb-wxkb/commit/bc1a5c0b953393583c19f8a068693f93f6d2bf23

JulianNorton commented 5 years ago

@modelm do you know how to remove the second "in"?

https://github.com/JulianNorton/weather-10kb-wxkb/commit/bc1a5c0b953393583c19f8a068693f93f6d2bf23

JulianNorton commented 5 years ago

Screen Shot 2019-06-12 at 9 35 43 AM

it's pulling from the same partial

modelm commented 5 years ago

That's coming from hourlyTime.fromNow() - one way would be something like hourlyTime.fromNow().replace(/in /, '')

ivanfrias commented 5 years ago

@JulianNorton @modelm If you want I can take this.I can try to normalize all the the strings that come from momentjs

Let me know your thoughts.

JulianNorton commented 5 years ago

Please do Ivan!

On Oct 3, 2019, at 6:29 AM, Ivan notifications@github.com wrote:

 @JulianNorton @modelm If you want I can take this.I can try to normalize all the the strings that come from momentjs

Let me know your thoughts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.